Repository navigation
Allow reading of legacy restraint settings for SepTop - #2237
Conversation
| assert settings.complex_integrator_settings.barostat == "MonteCarloMembraneBarostat" | ||
|
|
||
|
|
||
| def test_legacy_complex_restraint_settings(default_settings): |
There was a problem hiding this comment.
It might also make sense to just have a test somewhere that tries to load some legacy serialilzed Protocol?
There was a problem hiding this comment.
Yes, I think that could be useful, but maybe not blocking for this PR?
There was a problem hiding this comment.
Since opening this PR, our aim has changed from "concretely being able to support previous versions" to "just a shim to reduce the amount of work for this release". In that case, my view has changed to the following: adding the regression check isn't worth the time (edit: for a shim) - we can revisit this after the release if our strategy changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
- Coverage 95.13% 90.36% -4.78%
==========================================
Files 224 224
Lines 22009 22038 +29
==========================================
- Hits 20938 19914 -1024
- Misses 1071 2124 +1053
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
testing here: OpenFreeEnergy/ExampleNotebooks#334 |
hannahbaumann
left a comment
There was a problem hiding this comment.
Thanks @IAlibay , lgtm! The extra test would be great, but I would also say not blocking for this PR.
| assert settings.complex_integrator_settings.barostat == "MonteCarloMembraneBarostat" | ||
|
|
||
|
|
||
| def test_legacy_complex_restraint_settings(default_settings): |
There was a problem hiding this comment.
Yes, I think that could be useful, but maybe not blocking for this PR?
* add --name option to setup-task-campaign * Apply suggestion from @hannahbaumann Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com> * Allow reading of legacy restraint settings for SepTop (#2237) * Add fix for issue-2236 * Decouple the solvent and vacuum lambda schedules for the AHFE Protocol and remove redundant windows. (#2241) * Remove redundant gas phase lambda windows from the AHFE protocol * Decouple gas and solve phase lambda windows in the AHFE protocol settings. * main name arg required --------- Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com> Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
Fixes #2234
We don't usually do this, so I'm not 100% sure we actually want to do this here (instead of just generating new data).
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes
If yes, please provide details here: opus 5.5 to help generate some quick tests.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin