Skip to content

Allow reading of legacy restraint settings for SepTop - #2237

Merged
IAlibay merged 5 commits into
mainfrom
issue-2236
Oct 7, 2026
Merged

IAlibay merged 5 commits into
mainfrom
issue-2236

Conversation

@IAlibay

@IAlibay IAlibay commented Oct 5, 2026

Copy link
Copy Markdown
Member

Fixes #2234

We don't usually do this, so I'm not 100% sure we actually want to do this here (instead of just generating new data).

LLM / AI generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes
If yes, please provide details here: opus 5.5 to help generate some quick tests.

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.
  • Adhered to the contribution guidelines
  • Filled in the AI generated code disclosure.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

assert settings.complex_integrator_settings.barostat == "MonteCarloMembraneBarostat"


def test_legacy_complex_restraint_settings(default_settings):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might also make sense to just have a test somewhere that tries to load some legacy serialilzed Protocol?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that could be useful, but maybe not blocking for this PR?

@IAlibay IAlibay Oct 7, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since opening this PR, our aim has changed from "concretely being able to support previous versions" to "just a shim to reduce the amount of work for this release". In that case, my view has changed to the following: adding the regression check isn't worth the time (edit: for a shim) - we can revisit this after the release if our strategy changes.

@IAlibay
IAlibay requested a review from atravitz October 5, 2026 13:04
@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (b917eda) to head (797a46f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
- Coverage   95.13%   90.36%   -4.78%     
==========================================
  Files         224      224              
  Lines       22009    22038      +29     
==========================================
- Hits        20938    19914    -1024     
- Misses       1071     2124    +1053     
Flag Coverage Δ
fast-tests 90.36% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz added this to the 1.13.0 milestone Oct 5, 2026
@atravitz

atravitz commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

testing here: OpenFreeEnergy/ExampleNotebooks#334

@hannahbaumann hannahbaumann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IAlibay , lgtm! The extra test would be great, but I would also say not blocking for this PR.

assert settings.complex_integrator_settings.barostat == "MonteCarloMembraneBarostat"


def test_legacy_complex_restraint_settings(default_settings):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that could be useful, but maybe not blocking for this PR?

@IAlibay
IAlibay enabled auto-merge (squash) October 7, 2026 08:03
@IAlibay
IAlibay merged commit 7d9df80 into main Oct 7, 2026
9 checks passed
@IAlibay
IAlibay deleted the issue-2236 branch October 7, 2026 09:09
atravitz pushed a commit that referenced this pull request Oct 7, 2026
atravitz added a commit that referenced this pull request Oct 7, 2026
* add --name option to setup-task-campaign

* Apply suggestion from @hannahbaumann

Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>

* Allow reading of legacy restraint settings for SepTop (#2237)

* Add fix for issue-2236

* Decouple the solvent and vacuum lambda schedules for the AHFE Protocol and remove redundant windows. (#2241)

* Remove redundant gas phase lambda windows from the AHFE protocol
* Decouple gas and solve phase lambda windows in the AHFE protocol settings.

* main name arg required

---------

Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boresch restraint validation error

3 participants