Repository navigation
Let the force field resolve the partial charge assignment #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
cd183a8
try to get charges from the force field
jthorton d1ecb40
Merge branch 'main' into charge_from_ff
jthorton 46c5bbf
add forcefield option for charge assignment
jthorton f372a16
remove import
jthorton 7c0575e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 00692ec
fix rename, update error message
jthorton ebf4e78
Merge remote-tracking branch 'origin/charge_from_ff' into charge_from_ff
jthorton 3eb3600
update cli option, add readme
jthorton d700702
finish CLI support and test, file extension handling
jthorton 5083dd0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 38ff7c6
fix whitespace
jthorton 5fbd1ce
Merge branch 'main' into charge_from_ff
jthorton aec1d35
use the toolkits in the input settings
jthorton 5616dc1
fix whitespace
jthorton b9a332f
Merge branch 'main' into charge_from_ff
jthorton 8c4421f
PR feedback, update toolkit backends with nagl, add extra force field…
jthorton 76924a4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5610478
fix mypy
jthorton 0e50422
Merge branch 'main' into charge_from_ff
jthorton 6038475
Merge branch 'main' into charge_from_ff
jthorton 44102d9
catch forcefields is empty list
jthorton 4cb249d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cb3fa7b
use new charge settings class for the cli
jthorton 617f07f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 85af2be
Merge branch 'main' into charge_from_ff
jthorton 25d3928
remove whitespace
jthorton 870f030
Merge remote-tracking branch 'origin/charge_from_ff' into charge_from_ff
jthorton 998df08
Update src/openfe/protocols/openmm_utils/charge_generation.py
jthorton 289f674
Update src/openfe/protocols/openmm_utils/charge_generation.py
jthorton 9ef5b92
support vsite force fields, fix mypy
jthorton e53786f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d6cd80a
Merge branch 'main' into charge_from_ff
IAlibay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| **Added:** | ||
|
|
||
| * The ``assign_offmol_partial_charges`` and ``bulk_assign_partial_charges`` functions can assign charges from a list of OpenFF SMIRNOFF style force fields. Set method=``forcefield`` and provide a list of force field files via the new keyword argument ``forcefields``. This is also supported in the ``charge-molecules`` CLI command and is set by using a yaml settings file. | ||
|
|
||
| **Changed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Deprecated:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Removed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Fixed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Security:** | ||
|
|
||
| * <news item> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.