PHP 8.5 compatibility: Method ReflectionProperty::setAccessible is deprecated#206
Open
vovayatsyuk wants to merge 1 commit into
Open
PHP 8.5 compatibility: Method ReflectionProperty::setAccessible is deprecated#206vovayatsyuk wants to merge 1 commit into
vovayatsyuk wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes use of the deprecated ReflectionProperty::setAccessible() in the theme inspector’s block cache collection logic to restore PHP 8.5 compatibility (Magento 2.4.9), without introducing a backwards-compatibility concern for this project’s supported PHP versions.
Changes:
- Removed the
ReflectionProperty::setAccessible(true)call when reading_isScopePrivatevia reflection. - Continued to use
ReflectionProperty::getValue()inside the existingtry/catchfallback path for private-block detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use theme inspector with Magento 2.4.9 and PHP 8.5 I've got en exception:
Since this project doesn't support PHP 8.0, this is not a BC.
View Screenshot