type-c-services/tests: Convert std/unconstrained example to test#887
Open
RobertZ2011 wants to merge 2 commits into
Open
type-c-services/tests: Convert std/unconstrained example to test#887RobertZ2011 wants to merge 2 commits into
RobertZ2011 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports and formalizes Type‑C “unconstrained power” behavior by adding an integration test to the type-c-service test harness, adjusting test timing, and cleaning up an outdated std example.
Changes:
- Added a new integration test (
tests/unconstrained.rs) validating unconstrained state propagation across multiple Type‑C ports. - Increased the shared Type‑C integration test timeout window and ensured
logfeature propagation topower-policy-servicefor std/test builds. - Removed the old
type-c-unconstrainedstd example binary and its Cargo bin entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
type-c-service/tests/unconstrained.rs |
Adds an integration test for unconstrained-power behavior across 3 mocked ports. |
type-c-service/tests/common/mod.rs |
Extends the default integration test timeout window used by the Type‑C test harness. |
type-c-service/Cargo.toml |
Ensures power-policy-service/log is enabled when type-c-service is built with log. |
examples/std/src/bin/type_c/unconstrained.rs |
Removes an obsolete std example that is superseded by the new integration test. |
examples/std/Cargo.toml |
Removes the type-c-unconstrained bin target entry. |
e8d59ce to
4efaf8f
Compare
kurtjd
approved these changes
Jun 11, 2026
jerrysxie
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.