Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh clone cannot start: the training notebook is empty and the API imports a model artifact that does not exist. Add a reproducible offline Iris training example, complete the notebook, pin the Python 3.12 dependencies, and generate the artifact inside the Docker build.
Define the four-feature API contract and return JSON 422 errors for malformed requests, including non-finite numbers that previously broke error serialization. The README describes the feature order, class labels, measured holdout evaluation, setup and demo limits. Iris is an explicit teaching-dataset choice for the previously empty training step; it is not a production-data claim.
Validation: nine tests pass, the notebook executes, actual localhost prediction/docs/error flows pass, Ruff formatting/lint and workflow lint pass, and the pinned runtime audit reports no known vulnerabilities. Training fits 120 rows and evaluates 30 held-out rows. CI now exercises the Python pipeline and Docker build/smoke check; Docker is unavailable locally. No model binary, secret, container registry publication or deployment is included.