Skip to content

feat(acceptance): add bounded operator execution kit - #381

Merged
BunsDev merged 14 commits into
mainfrom
acceptance/196-operator-execution-kit
Sep 9, 2026
Merged

feat(acceptance): add bounded operator execution kit#381
BunsDev merged 14 commits into
mainfrom
acceptance/196-operator-execution-kit

Conversation

@BunsDev

@BunsDev BunsDev commented Sep 7, 2026

Copy link
Copy Markdown
Member

Objective

Provide the smallest repository-native execution kit for the remaining #196/#239 operator-observed acceptance work without reopening completed publication or packaging evidence.

The kit pins the acceptance evidence to the already-public macOS v0.0.1 release owned by those issues:

  • signed tag v0.0.1, tag object 6c628be321419c07c508e75c3652b44376d2ab3b;
  • accepted source commit 57c6c71bd5264fde960b062e95de278c8438c94f;
  • Apple Silicon DMG Psyche-Build-v0.0.1-aarch64.dmg, SHA-256 e0c8cce02cedc7b7cc122c4b453da8ccc665f42da457aa571c2c476d3f03c74f;
  • Intel DMG Psyche-Build-v0.0.1-x86_64.dmg, SHA-256 c6d62f8aeea1570f377fe6bc2d5c90f5b6a4701390af1c42073465f2a586e882.

It keeps exact-source smoke, packaged Tauri observation, current-source harness evidence, and the older Homebrew lifecycle record as separate evidence subjects. It does not close #196 or #239 and does not claim that operator observations have been performed.

Acceptance criteria

  • Bounded operator runbook defines preparation, execution, deferrals, evidence classification, and handoff.
  • Copyable manifest template preserves the existing 15-digest baseline and is pinned to v0.0.1.
  • Validator rejects unsupported fields, mismatched release/artifact identities, missing digests, unknown consequential outcomes, and false complete states.
  • Focused tests cover incomplete-template, identity, unknown-outcome, and completion boundaries.
  • Canonical release-acceptance documentation links the execution kit.

Non-goals

Touched surfaces

  • docs/OPERATOR-ACCEPTANCE-SLICE.md
  • docs/templates/operator-acceptance-v0.0.1.json
  • scripts/validate-operator-acceptance.mjs and declaration
  • __tests__/operatorAcceptanceManifest.test.ts
  • package command and canonical acceptance-doc link

No generated files, runtime paths, workflows, persisted product formats, credentials, network authority, or external effects are changed.

Verification

Against branch head 7a520f48:

pnpm vitest --run __tests__/operatorAcceptanceManifest.test.ts
# 1 file / 5 tests passed

pnpm acceptance:validate -- docs/templates/operator-acceptance-v0.0.1.json
# structurally valid and incomplete

pnpm typecheck:tests
# passed

bash ./scripts/agent-check fast
# passed

Hosted required checks remain authoritative for the updated exact head. Refs #196 and #239.

@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
psyche-build-docs Ready Ready Preview Sep 9, 2026 7:11am UTC

Request Review

@BunsDev

BunsDev commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@codex review

Please review exact head 4fb8d9f1 after hardening the validator against malformed nested manifest input. Confirm the v0.0.1 release pin and report any remaining acceptance-contract or untrusted-input findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T06:12:13.028765Z f0cb9c8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Provided git ref 4fb8d9f1b57d15fcb2a161552e93a04f20b90134 does not exist
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BunsDev
BunsDev marked this pull request as ready for review September 9, 2026 01:42
Copilot AI lite review requested due to automatic review settings September 9, 2026 01:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new runbook/documentation conflicts with validator-required fields for inapplicable observations and the canonical doc link likely breaks in packaged docs unless the referenced files are shipped.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds a repository-native “operator acceptance execution kit” for the already-published macOS v0.0.1 release, centered around a pinned manifest template plus a strict validator and focused tests to prevent invalid/over-claimed acceptance states.

Changes:

  • Introduces a pinned operator-acceptance manifest schema + CLI validator enforcing release/artifact identity and completion boundaries.
  • Adds a copyable v0.0.1 manifest template and a bounded operator runbook describing how to collect and classify evidence.
  • Adds Vitest coverage for the validator/template and wires a new pnpm acceptance:validate script.
File summaries
File Description
scripts/validate-operator-acceptance.mjs Implements the manifest schema validation + CLI entrypoint.
scripts/validate-operator-acceptance.d.mts Adds TS typings for importing the validator from .mjs.
package.json Adds acceptance:validate npm script.
docs/templates/operator-acceptance-v0.0.1.json Provides the pinned, intentionally-incomplete manifest template.
docs/RELEASE-ACCEPTANCE.md Links canonical release acceptance doc to the new operator runbook.
docs/OPERATOR-ACCEPTANCE-SLICE.md Adds the bounded operator runbook for collecting evidence.
tests/operatorAcceptanceManifest.test.ts Adds focused tests for template validity and validator boundaries.
Review details
  • Files reviewed: 7/7 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/RELEASE-ACCEPTANCE.md
Comment thread docs/OPERATOR-ACCEPTANCE-SLICE.md Outdated
@BunsDev

BunsDev commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@codex review

Please re-review exact head 48405eb3 after fixing the packaged-docs template link and documenting the required fields for inapplicable observations. Confirm both Copilot findings are resolved and report any remaining issue.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48405eb395

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/validate-operator-acceptance.mjs
Comment thread scripts/validate-operator-acceptance.mjs
Comment thread scripts/validate-operator-acceptance.mjs
Comment thread scripts/validate-operator-acceptance.mjs
@BunsDev

BunsDev commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@codex review

Please re-review exact head 7a520f48 after enforcing zero exit for successful source smoke and requiring safeNextAction for inapplicable observations. Confirm the two remaining findings are resolved.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a520f48bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/validate-operator-acceptance.mjs
@BunsDev

BunsDev commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@codex review

Please review exact head f0cb9c89 after restricting inapplicable to supported-agent-lane, requiring successful-smoke host metadata, and validating observedAt as an ISO timestamp. Report any remaining acceptance-contract issue.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0cb9c8946

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/validate-operator-acceptance.mjs
Comment thread scripts/validate-operator-acceptance.mjs
BunsDev and others added 8 commits September 9, 2026 02:10
Align the bounded operator manifest, validator, runbook, and tests with the v0.0.1 release contract owned by issues #196 and #239.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Return validation errors for malformed untrusted observation and metadata sections instead of throwing during completion checks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use a stable repository template link and document validator fields for unavailable agent lanes without expanding the npm docs allowlist.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Require successful source smoke to exit zero and require a safe-next-action reason for inapplicable observations before closure.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@BunsDev
BunsDev force-pushed the acceptance/196-operator-execution-kit branch from f0cb9c8 to ad73a94 Compare September 9, 2026 07:10
@BunsDev
BunsDev merged commit 41f2c52 into main Sep 9, 2026
13 checks passed
@BunsDev
BunsDev deleted the acceptance/196-operator-execution-kit branch September 9, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Close the v0.0.1 runtime acceptance and stabilization baseline

2 participants