feat(acceptance): add bounded operator execution kit - #381
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cb838c9 to
858674b
Compare
|
@codex review Please review exact head |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
🟡 Changes recommended
The new runbook/documentation conflicts with validator-required fields for inapplicable observations and the canonical doc link likely breaks in packaged docs unless the referenced files are shipped.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a repository-native “operator acceptance execution kit” for the already-published macOS v0.0.1 release, centered around a pinned manifest template plus a strict validator and focused tests to prevent invalid/over-claimed acceptance states.
Changes:
- Introduces a pinned operator-acceptance manifest schema + CLI validator enforcing release/artifact identity and completion boundaries.
- Adds a copyable
v0.0.1manifest template and a bounded operator runbook describing how to collect and classify evidence. - Adds Vitest coverage for the validator/template and wires a new
pnpm acceptance:validatescript.
File summaries
| File | Description |
|---|---|
| scripts/validate-operator-acceptance.mjs | Implements the manifest schema validation + CLI entrypoint. |
| scripts/validate-operator-acceptance.d.mts | Adds TS typings for importing the validator from .mjs. |
| package.json | Adds acceptance:validate npm script. |
| docs/templates/operator-acceptance-v0.0.1.json | Provides the pinned, intentionally-incomplete manifest template. |
| docs/RELEASE-ACCEPTANCE.md | Links canonical release acceptance doc to the new operator runbook. |
| docs/OPERATOR-ACCEPTANCE-SLICE.md | Adds the bounded operator runbook for collecting evidence. |
| tests/operatorAcceptanceManifest.test.ts | Adds focused tests for template validity and validator boundaries. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@codex review Please re-review exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48405eb395
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a520f48bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
7a520f4 to
f0cb9c8
Compare
|
@codex review Please review exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0cb9c8946
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Return validation errors for malformed untrusted observation and metadata sections instead of throwing during completion checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use a stable repository template link and document validator fields for unavailable agent lanes without expanding the npm docs allowlist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Require successful source smoke to exit zero and require a safe-next-action reason for inapplicable observations before closure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
f0cb9c8 to
ad73a94
Compare
Objective
Provide the smallest repository-native execution kit for the remaining #196/#239 operator-observed acceptance work without reopening completed publication or packaging evidence.
The kit pins the acceptance evidence to the already-public macOS
v0.0.1release owned by those issues:v0.0.1, tag object6c628be321419c07c508e75c3652b44376d2ab3b;57c6c71bd5264fde960b062e95de278c8438c94f;Psyche-Build-v0.0.1-aarch64.dmg, SHA-256e0c8cce02cedc7b7cc122c4b453da8ccc665f42da457aa571c2c476d3f03c74f;Psyche-Build-v0.0.1-x86_64.dmg, SHA-256c6d62f8aeea1570f377fe6bc2d5c90f5b6a4701390af1c42073465f2a586e882.It keeps exact-source smoke, packaged Tauri observation, current-source harness evidence, and the older Homebrew lifecycle record as separate evidence subjects. It does not close #196 or #239 and does not claim that operator observations have been performed.
Acceptance criteria
v0.0.1.completestates.Non-goals
v0.0.1release.v0.0.1lifecycle evidence as packaged GUI evidence.Touched surfaces
docs/OPERATOR-ACCEPTANCE-SLICE.mddocs/templates/operator-acceptance-v0.0.1.jsonscripts/validate-operator-acceptance.mjsand declaration__tests__/operatorAcceptanceManifest.test.tsNo generated files, runtime paths, workflows, persisted product formats, credentials, network authority, or external effects are changed.
Verification
Against branch head
7a520f48:Hosted required checks remain authoritative for the updated exact head. Refs #196 and #239.