chore(conformance): repin Cave authority - #146
Open
BunsDev wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The repin is applied consistently across lockfiles, tests, and documentation, and no remaining references to the previous Cave revision appear to conflict with the new pin.
Pull request overview
This PR repins the protected conformance/contract canary locks and related assertions to the merged Cave authority fix commit bc310e9753783678014086ed6f7ef7d3fb797967 (release 0.3.12), keeping the Phase 1 conformance inputs consistent across lockfiles, tests, and documentation.
Changes:
- Update Cave
revisionpin from6325fc4c...tobc310e97...across lock JSONs. - Update test expectations to match the new Cave authority revision.
- Refresh Phase 1 conformance documentation to reflect the new Cave authority commit/tree.
File summaries
| File | Description |
|---|---|
| src/specification-guards.test.ts | Updates lock expectation for Cave revision. |
| src/phase1-conformance-lock.test.ts | Updates expected lock entries for Cave revision. |
| src/contract-canary-artifact-root.test.ts | Updates canary lock assertions/typed input shapes for Cave revision. |
| phase1-conformance.lock.json | Repins Cave revision in the Phase 1 conformance lock. |
| docs/phase1-conformance.md | Updates documented Cave authority commit/tree for the pinned inputs. |
| contract-canary.lock.json | Repins Cave revision in the contract canary lock. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SDK rebound its conformance/client-v1-cross-repository-lock.json sources.cave pin to the new Cave v0.3.12 conformance commit in OpenCoven/sdk#151 (merged as 2d1cb15fcb47ff6577ccae1186c74ded69b82fc8). This updates Chat's vendored, provenance-verified fixture of that real SDK file (renamed sdk-933a9523/ -> sdk-2d1cb15f/) to mirror the new committed bytes, and corrects the associated test expectations: - fixture root path and phase1CompatibilityValidator commit/tree - frozenLock provenance (commit/tree/blob/size/sha256) - frozenLock.evidenceProducer, which had a stale literal unrelated to the cave change but was already drifted from Chat's real current producer pin (ada542f...) recorded in the SDK file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repin the protected conformance lock to the merged v0.3.12 Cave authority fix bc310e9753783678014086ed6f7ef7d3fb797967.
Validation: targeted authority tests, typecheck, and Biome checks pass.