fix(conformance): retain locked Chat revision for nested checkout - #144
Closed
BunsDev wants to merge 2 commits into
Closed
fix(conformance): retain locked Chat revision for nested checkout#144BunsDev wants to merge 2 commits into
BunsDev wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
BunsDev
marked this pull request as ready for review
September 7, 2026 08:08
Member
Author
|
Superseded by the already-merged #143, which retains the required Chat history for the nested locked checkout. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are internally consistent across workflow, lock, tests, and documentation, and directly address the reported Windows shallow-checkout failure mode without introducing apparent regressions.
Pull request overview
This PR hardens phase1 conformance’s authority locking on Windows by ensuring the locked Chat revision is fetched (and retained via a local ref) before schema-v2 style nested checkouts rely on it, preventing failures when the initial checkout is shallow.
Changes:
- Repins the harness authority revision/tree and updates the recorded workflow blob + SHA-256 across the lock file and lock tests.
- Extends the protected Windows bootstrap to validate
phase1Lock.chatand fetch/tag the locked Chat revision for reachability. - Updates conformance documentation to reflect the new committed workflow byte size and digest.
File summaries
| File | Description |
|---|---|
src/phase1-conformance-lock.test.ts |
Updates the expected harness authority revision/tree and workflow blob/SHA assertions to match the new lock authority. |
src/client-v1-conformance-workflow.test.ts |
Adds a regression guard ensuring the protected Windows bootstrap contains the new Chat revision fetch + local ref anchor. |
phase1-conformance.lock.json |
Repins harness authority to the new revision/tree and updates the workflow blob/SHA record. |
docs/phase1-conformance.md |
Updates the documented workflow byte count and SHA-256 to match the new pinned workflow bytes. |
.github/workflows/client-v1-conformance.yml |
Validates phase1Lock.chat and fetches/tags the locked Chat revision to prevent shallow-clone object absence during nested operations. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
Protected run 34091592534 showed Windows failing at phase1.stage.checkouts.chat.failed because the locked historical Chat object was absent from the shallow source clone.