fix(conformance): classify report secret-scan failures - #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report secret-scan rejections were incorrectly attributed to
phase1.stage.evidence-authority.report.failed. Use the existingphase1.stage.evidence-authority.scan.failedboundary so protected-run diagnostics identify the failed operation.Addresses the unresolved review in #140: #140 (comment). The producer byte count/digest, workflow authority, lock, and expected authority fixtures are refreshed together.
Validation:
report.failedbefore the patch, passes withscan.failedafterward.Merge with an actual merge commit: the lock references behavior commit
667750af2ef5d2ea14ec4e825e1bd54a57e771f5, which must remain an ancestor. This diagnostic correction does not substitute for the downstream SDK validator rebind and protected matrix rerun.