Feature/issue 1864 optional domain hint#1984
Merged
kayjoosten merged 6 commits intomainfrom Apr 23, 2026
Merged
Conversation
…sts (#1864) When coin:azure_domain_hint is set on an IdP, EngineBlock appends a whr=<domain> query parameter to the HTTP-Redirect URL it sends as the AuthnRequest to that IdP. This allows Microsoft Azure / EntraID to skip the account picker for users whose realm is already known. - Add azureDomainHint field + getter to Coins (IdP coins) - Add azureDomainHint constructor param to IdentityProvider entity - Map metadata:coin:azure_domain_hint in PushMetadataAssembler - Append whr= in Bindings::send() HTTP-Redirect branch when IdP has the coin - Integration test: azure_domain_hint coin round-trips through PushMetadataAssembler - Legacy test: Bindings appends / omits whr= based on coin presence - Behat scenario: AzureDomainHint.feature covers the full SSO flow
Added IDP "<name>" prefers HTTP Redirect binding step and used it in the negative scenario so the URL assertion fires at the actual IdP redirect URL rather than at an intermediate EngineBlock page.
johanib
reviewed
Apr 22, 2026
Contributor
johanib
left a comment
johanib
left a comment
There was a problem hiding this comment.
Looks good! One minor edgecase we might improve
johanib
reviewed
Apr 22, 2026
kayjoosten
force-pushed
the
feature/issue-1864-optional-domain-hint
branch
from
3f83638 to
c296f03
Compare
johanib
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.