#2008 reference delete#21
Open
jamlung-ri wants to merge 7 commits into
Open
Conversation
snyaggarwal
reviewed
May 12, 2026
Contributor
There was a problem hiding this comment.
UI Issues:
1. Button label needs to be title case and not upper case
2. There is no need to tell "0 mappings" same as what we show in listing
1. When there are multiple references selected the dialog is not saying much, should be show distribution here?
1. In Reference details -> actions -> delete is not implemented
- Added delete confirmation dialog for references in ReferenceHome component. - Updated ReferenceHeader to handle delete action. - Improved ReferenceManagementList to conditionally enable delete button with tooltip. - Adjusted translations for delete confirmation messages. - Updated package dependencies in package.json and package-lock.json.
Member
Author
|
Thanks @snyaggarwal! I pushed some more changes. I didn't do the distribution part though, since I don't have a good sense of the value. I think we can defer it to later, but open to discussion. |
snyaggarwal
reviewed
May 14, 2026
|
|
||
| const getCollectionLookupUrl = url => (url || '').replace(/\/(concepts|mappings|references)\/?$/, '/') | ||
|
|
||
| const isHeadCollectionUrl = url => { |
Contributor
There was a problem hiding this comment.
this is still fragile.
Ideal way would be to pass repo as prop from RepoHome to Search component
and here in Search check when props.nested is true then props.repo.version
Member
Author
|
Thanks Sunny! Changes pushed! |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #2008
Summary
See ticket