Skip to content

feat(settings): add missing shared resolution presets - #1407

Merged
capy-ai[bot] merged 3 commits into
devfrom
capy/add-missing-shared-resolution
Nov 4, 2026
Merged

capy-ai[bot] merged 3 commits into
devfrom
capy/add-missing-shared-resolution

Conversation

@zortos293

@zortos293 zortos293 commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Add 1112×834, 1024×768, 1366×768, 1280×1024, 1680×720 and 1600×1200 to the shared desktop/console resolution list, with 4:3 and 5:4 groups. Preserve the 3456×2160 preset, its existing 3.5K label and its H.264 exception now supplied by merged #1300. Both catalogs contain the same 28 unique dimensions.

Synchronize the native fallback catalog without changing the selection algorithm or decoder limits. Under the existing closest-aspect-then-area rule, Hantro-limited H.264 3440×1440 now falls back to 1680×720 instead of 1920×1080. The existing limited-HEVC 3840×2400 → 3456×2160 behavior from dev is preserved.

Extend the existing console settings workload to exercise the real desktop picker too, covering unique sizes, grouping, offline options, unsupported entitlements, custom dimensions and serialized/confirmed selections on both surfaces. Decoder regressions cover all seven originally requested unambiguous modes, preserve the merged unbounded H.264 3.5K exception and separately prove its dimension-bounded fallback. Keep custom-resolution coverage at 1234×800 now that 1366×768 is a preset.

Partially addresses #1372. Requested 3640×1080 remains ambiguous against existing 3840×1080 and is deliberately not guessed.

Merge integration at 1f32d4a5 incorporates the eight other authorized merges without reverting their behavior. All 56 focused streamer-configuration tests, the full core suite (936 passed, 4 ignored), the full native streamer workspace (1458 passed, 14 ignored), strict all-target core Clippy and formatting pass. The full combined Qt application build and all 591 Qt tests pass, and all seven exact-head CI checks pass. The fresh automatic review failed because the model provider rate-limited it; no new findings were recorded. An independent exact-head Sol code review completed with no blocking defects as a substitute before the authorized merge. It verified catalog uniqueness/parity, unchanged normalization and decoder limits, preservation of dev's 3.5K H.264 exception, unchanged entitlement/persistence paths and acceptance-only fixture injection, and independently reran four compiled contract tests successfully. Real membership, hardware streaming and live-account disk-restart acceptance remain unverified. No localization, protocol or decoder-limit changes in this PR.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7f710ede-0353-45ca-b71b-a40d7ec54a9e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found 1 potential issue (1 medium).

Open in Capy

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 2 other findings in Capy.

Open in Capy

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@capy-ai

capy-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Independent exact-head code review completed for 1f32d4a59d65769235da2acf8a7c2c84b5d77e13 against dev 65f54a98: no blocking defects. This substitutes for the automatic review that failed with LLM.Error.RateLimit; that failure is not being counted as a clean review.

The Sol reviewer independently verified both 28-entry catalogs, the byte-identical native normalization/decoder limits, preserved dev 3.5K/H.264 behavior, unchanged entitlement/persistence paths and acceptance-only injection. Four compiled catalog/decoder contract tests independently pass. Full combined verification also passes: 936 core tests (4 ignored), 1458 native streamer tests (14 ignored), all 591 rebuilt Qt tests, strict core Clippy/formatting and all seven exact-head CI checks.

Proceeding under the user's explicit merge instruction. Existing live membership, physical hardware, native macOS proxy and provider acceptance limits remain; this does not authorize issue closure.

@capy-ai
capy-ai Bot merged commit 1c88e21 into dev Nov 4, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant