Skip to content

fix(accounts): normalize accepted account-link callback sockets - #1405

Merged
capy-ai[bot] merged 1 commit into
devfrom
fix/account-callback-blocking-socket
Nov 3, 2026
Merged

capy-ai[bot] merged 1 commit into
devfrom
fix/account-callback-blocking-socket

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

Account-link callbacks use a nonblocking listener so pending attempts can be cancelled. Accepted sockets can inherit that mode on Windows, causing reads to fail before the browser sends its headers even though a read timeout is configured.

Normalize each accepted stream to blocking mode and require its existing two-second read timeout and a matching write timeout to be installed successfully. Provider validation, callback parsing, cancellation, ownership and redirect behavior are unchanged.

Add a regression that establishes TCP, delays complete HTTP headers by 100 ms, then checks the real callback values and success redirect. The test passes before and after on Linux, where accepted streams are already blocking. An existing Windows GOG callback test failed with ConnectionAborted during #1287 CI; exact Windows recovery remains to be verified, rather than inferred from Linux.

Verified on a fresh, source-isolated core target: 57 account-filtered tests, the full core suite with 911 passed and 4 ignored, formatting and strict all-target Clippy. Parent independently inspected the one-file diff and reran all 13 account_connections::tests successfully.

This is separate from the RTT changes in #1287.

Open in Capy

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f3b589fd-18e5-4ad3-8145-e39568129b5b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

Open in Capy

@capy-ai

capy-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Exact-head validation is complete at 2a624bb5: all seven CI checks pass, including Linux, macOS and Windows, and automatic review completed without findings. Windows job 126189298696 actually ran and passed both the new delayed-header regression and the existing GOG account-discovery callback test.

This establishes Windows after-fix behavior. It does not isolate this socket-mode hazard as the sole cause of the earlier #1287 CI abort, and no live GOG account was tested. The PR remains open and unmerged.

@capy-ai
capy-ai Bot merged commit f08294e into dev Nov 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant