Repository navigation
fix(webrtc): align native signaling with the v3 wire contract - #1400
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh native WebRTC connections now use the same signaling 3.0 URL as reconnects. Peer registration advertises version 3,
signalingVersion: "3.0",peer_role: 1and the full browser version, matching the wire fields in merged Android #1392. The provider endpoint, session/peer identity, authentication headers, cancellation and bounded I/O are unchanged.Refs #1379. Its diagnostics establish signaling failure with zero media, not an exact version rejection. This corrects a concrete native contract mismatch; it is not a demonstrated live GAME+ fix. #1392 also changed Android allocation behavior, so its reported YES success does not isolate signaling as the cause.
Verification:
Live GAME+/NVIDIA/provider compatibility and platform GPU presentation still require authenticated hardware acceptance.