Skip to content

fix(webrtc): align native signaling with the v3 wire contract - #1400

Merged
capy-ai[bot] merged 2 commits into
devfrom
capy/align-native-signaling-with
Nov 3, 2026
Merged

capy-ai[bot] merged 2 commits into
devfrom
capy/align-native-signaling-with

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

Fresh native WebRTC connections now use the same signaling 3.0 URL as reconnects. Peer registration advertises version 3, signalingVersion: "3.0", peer_role: 1 and the full browser version, matching the wire fields in merged Android #1392. The provider endpoint, session/peer identity, authentication headers, cancellation and bounded I/O are unchanged.

Refs #1379. Its diagnostics establish signaling failure with zero media, not an exact version rejection. This corrects a concrete native contract mismatch; it is not a demonstrated live GAME+ fix. #1392 also changed Android allocation behavior, so its reported YES success does not isolate signaling as the cause.

Verification:

  • Three signaling regressions fail against the original implementation; all nine pass after correction.
  • A bounded localhost WebSocket exchange covers fresh/reconnect registration, session headers, heartbeat/ACK, offer and nested answer. Existing full media fixtures now require the v3 fields.
  • All 247 core-crate tests and 1,457 streamer workspace tests pass; 14 existing environment-dependent tests remain ignored.
  • Strict core all-target Clippy, workspace formatting and diff checks pass. Parent independently reviewed all three files and reran the nine signaling tests and formatting.

Live GAME+/NVIDIA/provider compatibility and platform GPU presentation still require authenticated hardware acceptance.

Open in Capy

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2c5fc43f-5b37-4d47-9599-8e40d756a1e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

Open in Capy

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 1 other finding in Capy.

Open in Capy

@capy-ai
capy-ai Bot merged commit 7183db9 into dev Nov 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant