Skip to content

fix(core): retire allocation recovery on native session end - #1399

Merged
capy-ai[bot] merged 1 commit into
devfrom
fix/session-end-allocation-cleanup
Nov 3, 2026
Merged

capy-ai[bot] merged 1 commit into
devfrom
fix/session-end-allocation-cleanup

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

A completed native session no longer leaves its durable allocation-recovery record behind and blocks every later launch with session_allocation_unresolved when discovery is unavailable.

The existing account/provider/seat and pending-handoff checks still gate acknowledgement. Exact-seat completion clears durable recovery state before releasing active ownership, preserves ownership if deletion fails, and permits a safe retry. It does not issue a network DELETE for a session that has already authoritatively ended or weaken general recovery cleanup.

Refs #1395. The protocol reference now documents this ordering.

Verification:

  • Real-create/handoff regressions cover restart persistence, foreign account/provider/seat notifications, pending handoff and durable-delete failure with retry. Two regressions fail before the fix.
  • All 52 routing tests pass; the full core suite passes 914 tests with 4 ignored.
  • Formatting, strict all-target Clippy and diff checks pass.
  • The parent independently reran all seven native-session-end tests.

Live authenticated Windows gameplay and the exact reported spinner presentation were not exercised.

Open in Capy

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 19a676e8-9afe-4e70-8f71-a94523370d86

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 1 other finding in Capy.

Open in Capy

@capy-ai
capy-ai Bot merged commit f4c121a into dev Nov 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant