Skip to content

fix(input): release tracked mouse buttons after capture loss - #1398

Open
zortos293 wants to merge 1 commit into
devfrom
fix/mouse-release-capture-loss
Open

zortos293 wants to merge 1 commit into
devfrom
fix/mouse-release-capture-loss

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

Preserve mouse-button ownership when a release arrives after capture becomes inactive. Tracked Qt presses still send their matching release, native raw input retains button forwarding ownership, and a deferred cursor-mode change completes after the last tracked release.

Refs #1397. This hardens the release-handler contract; the reported Linux Mint/X11 capture-flicker sequence and live GFN behavior remain unverified. Ordinary X11 capture deactivation already flushes held input.

Verification:

  • The eight-case mouseReleaseSurvivesCaptureLoss regression fails before the change and passes afterward under offscreen and xcb/Xvfb, covering windowed/fullscreen, absolute/relative and stubbed raw/Qt ownership.
  • The complete streamvideo test passes.
  • Debug configure/build and all 588 Qt CTest workloads pass.

The raw-input rows validate Qt duplicate suppression with a stub API, not a native raw backend or a real streaming session.

Open in Capy

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f925b4c4-f5bf-4fc2-b086-d0e649255c82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 1 other finding in Capy.

Open in Capy

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant