Repository navigation
webui: remove the ReGa version selection - #193
Merged
Merged
Conversation
The maintenance page offered a choice between ReGaHss variants and wrote it to /etc/config/ReGaHssVersion. OpenCCU only installs a single ReGaHss binary, so the selection had no effect and is removed. Applies OpenCCU rootfs patch 0008-WebUI-Disable-ReGa.
2 of 12 tasks
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description Check | |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title "webui: remove the ReGa version selection" matches the main change. The PR removes the logic-layer (ReGa) version row from the maintenance page, along with the User.getReGaVersion and User.s… |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
With the selection gone from the maintenance page, nothing uses the User.getReGaVersion and User.setReGaVersion API methods any more. They read and wrote /etc/config/ReGaHssVersion to choose between ReGaHss variants that OpenCCU no longer ships. Remove both methods, their scripts and the translation keys of the removed maintenance page row.
jens-maus
changed the title
jens-maus
added a commit
to OpenCCU/OpenCCU
that referenced
this pull request
Oct 14, 2026
This removes OpenCCU rootfs patch 0008-WebUI-Disable-ReGa.patch, now that OpenCCU/OpenCCU-Base#193 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original OpenCCU rootfs patch: 0008
Original filename:
0008-WebUI-Disable-ReGa.patchOriginal patch: https://github.com/OpenCCU/OpenCCU/blob/6bb0e1690/buildroot-external/package/openccu-base/rootfs-patches/0008-WebUI-Disable-ReGa.patch (as extended by OpenCCU/OpenCCU#4431)
Original changes: OpenCCU/OpenCCU@39f1c8309 (split out of the former single RaspberryMatic patch)
Extension before migration: OpenCCU/OpenCCU#4431
The maintenance page ("Systemsteuerung > Zentralen-Wartung") has a "Version Logikschicht" row. It offers a choice between ReGaHss variants (
NORMAL,COMMUNITY) throughUser.getReGaVersion/User.setReGaVersion, writes the choice to/etc/config/ReGaHssVersionand offers a reboot. OpenCCU installs only one/bin/ReGaHssand removes allReGaHss.*variants, so the selection has no effect. The original rootfs patch only removed the row; OpenCCU/OpenCCU#4431 extends it to remove the rest of the selection. This applies the extended patch 1:1:src/webui/www/config/cp_maintenance.cgi: the "Version Logikschicht" table row (select box, save button and help text) and its JavaScript block (User.getReGaVersion,saveRegaVersion(),User.setReGaVersionand the reboot dialog) are removed. Nothing else on the page usessaveRegaVersion,#selectedReGaVersionor#showReGaVersionHelp.src/webui/www/api/methods.conf: theUser.getReGaVersionandUser.setReGaVersionAPI methods are removed.src/webui/www/api/methods/user/getregaversion.tclandsetregaversion.tcl: their scripts are removed.User.setReGaVersionlet any user withUSERlevel write an arbitrary value to/etc/config/ReGaHssVersion.src/webui/www/webui/js/lang/{de,en}/translate.lang.{extension,help,label,option}.js: the keysdialogRestart2ChanceReGaVersion,lblTDReGaVersionHelp,lblTDRegaVersion,optionReGaCOMMUNITY,optionReGaLEGACYandoptionReGaNORMALare removed.dialogHelpInfoLblVersionstays becausehelp.cgistill uses it.No other file in this repository references these methods or keys. The OpenCCU init script
S70ReGaHssis simplified in OpenCCU/OpenCCU#4431 as well;DEBUGin/etc/config/ReGaHssVersionstill starts ReGaHss in debug mode there.Line endings and encodings are preserved. The root
www/copies are unused legacy files and are left unchanged.Other OpenCCU rootfs patches also modify
cp_maintenance.cgi(0001, 0007, 0012, 0031, 0089, 0135, 0163, 0164 and 0165),methods.confand the language files. They still apply with zero fuzz.Validation
scripts/base-patch-migration.py validatewith the canonical Buildroot 2026.08git4archive of this branch (4c3457f7,mainmerged in, sha25627f94cc6c0c17fe3dfae6d7637c20f0705f13b6bb22912681e32b2e337825fe1) and--skip-patch 0008, on OpenCCUmaster(6bb0e1690, with the extended rootfs patch from refactor(webui): remove the remaining ReGa version selection OpenCCU#4431, current pindf07a0ec): PASS (the other 57 rootfs patches apply with zero fuzz).compareagainst a fresh validation of the current pindf07a0ecwith all 58 patches, the extended 0008 included: IDENTICAL (4666 entries).node --checkpasses for the eight changed language files.OpenCCU cleanup PR (removing patch 0008 and updating the pin): OpenCCU/OpenCCU#4432
Generated by Claude Code