AI review fixes for #3957 - #3961
Merged
jmthomas merged 1 commit intoOct 1, 2026
Merged
Conversation
- openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/Openc3Screen.vue:255 - JSON comparison threw on telemetry arrays containing BigInts; replaced it with recursive equality. - openc3-cosmos-init/plugins/packages/openc3-vue-common/src/widgets/VWidget.js:84 - The fade watcher could compare the previous rendered value and stop fading prematurely; it now reads the current computed value. AI-Review-Bot: true AI-Review-Run: 36745680936
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## perf/screen-skip-unchanged-values #3961 +/- ##
==================================================================
Coverage 80.14% 80.14%
==================================================================
Files 901 901
Lines 68386 68380 -6
Branches 2706 2654 -52
==================================================================
- Hits 54805 54804 -1
+ Misses 12916 12908 -8
- Partials 665 668 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
jmthomas
approved these changes
Oct 1, 2026
jmthomas
merged commit Oct 1, 2026
4388886
into
perf/screen-skip-unchanged-values
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the AI review of #3957 at bb3e1ae. Merge this PR to apply them to
perf/screen-skip-unchanged-values; the review summary is on #3957.