Skip to content

fix(table manager): edits of a table are saved when using Save As - #3960

Open
calmonroe wants to merge 2 commits into
mainfrom
3811-fix-save-as-overwrite
Open

calmonroe wants to merge 2 commits into
mainfrom
3811-fix-save-as-overwrite

Conversation

@calmonroe

Copy link
Copy Markdown
Contributor

What changed

Updates TableManger.vue to save existing edits when executing Save As
Ensures proper file locking and error handling should a save fail

Why it changed

Closes #3811

Testing strategy

Added playwright test to cover new code. Ran unit & playwright tests

@calmonroe calmonroe linked an issue Sep 29, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.34694% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.15%. Comparing base (e3a728f) to head (0698bcb).

Files with missing lines Patch % Lines
...blemanager/src/tools/TableManager/TableManager.vue 67.34% 14 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3960      +/-   ##
==========================================
+ Coverage   80.13%   80.15%   +0.02%     
==========================================
  Files         901      901              
  Lines       68370    68374       +4     
  Branches     2699     2650      -49     
==========================================
+ Hits        54789    54807      +18     
+ Misses      12913    12901      -12     
+ Partials      668      666       -2     
Flag Coverage Δ
frontend 67.06% <67.34%> (+0.07%) ⬆️
python 80.13% <ø> (+<0.01%) ⬆️
ruby-api 82.69% <ø> (+0.10%) ⬆️
ruby-backend 85.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@calmonroe
calmonroe marked this pull request as ready for review September 30, 2026 16:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table Manager Save As overwrite edits don't save

1 participant