fix: correct role assignment in chat_history and typo in get_embedding - #166
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
- chat_history.py: messages from other agents should be "user" role not "assistant" to maintain proper conversation alternation for models like LLAMA that require user/assistant/user alternation - openai.py: fix NameError in get_embedding exception handler where 'attempt' was used instead of 'attempts' parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes:
chat_history.py: In
to_messages(), messages from other agents (i.e., notmy_nameand not "function") were incorrectly assigned "assistant" role. These should be "user" role to maintain proper conversation alternation required by models like LLAMA that enforce user/assistant/user alternation.openai.py: Fixed
NameErroringet_embedding()exception handler whereattemptwas used instead ofattempts(the function parameter).Why
Issue why the to_message function in chat_history.py is trying to add an assistent message?聽#133: When using LLAMA models via vLLM, the API returns
BadRequestError: Conversation roles must alternate user/assistant/user/assistant/...because messages from other agents in multi-agent conversations were being labeled as "assistant" role.The
get_embeddingfunction has a bug where if an exception occurs, it tries to increment an undefined variableattemptinstead of the parameterattempts.Testing
my_namemessages are labeled "assistant" and "function" messages are labeled "function" - messages from other agents should logically be "user".