Repository navigation
Keep focus in Generate Trace view on update of pre-validation results - #1287
Conversation
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused restoration logic and regression coverage address the reported issue without identified blocking defects.
0 open findings
What changed in this PR
Preserves active text edits in the Generate Trace view when pre-validation results refresh.
Changes:
- Restores focus, draft text, and selection when the field remains unchanged.
- Adds regression tests for restoration, stale-edit guards, and existing focus and scroll behavior.
| File | Description |
|---|---|
| src/webviews/trace-configuration/src/trace-configuration.ts | Preserves active text input across compatible updates. |
| src/webviews/trace-configuration/src/trace-configuration.test.ts | Adds renderer fixtures and focus-preservation tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jreineckearm
left a comment
There was a problem hiding this comment.
Tested and can confirm that the focus is now kept. Thanks!

Fixes
Changes
Screenshots
Checklist