Skip to content

Keep focus in Generate Trace view on update of pre-validation results - #1287

Merged
JonatanAntoni merged 2 commits into
mainfrom
keep-focus
Oct 15, 2026
Merged

JonatanAntoni merged 2 commits into
mainfrom
keep-focus

Conversation

@JonatanAntoni

Copy link
Copy Markdown
Member

Fixes

Changes

  • Keep UI focus when updating pre-validation results

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh

qltysh Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

All good ✅

Comment thread src/webviews/trace-configuration/src/trace-configuration.ts
Comment thread src/webviews/trace-configuration/src/trace-configuration.ts
@qltysh

qltysh Bot commented Oct 15, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused restoration logic and regression coverage address the reported issue without identified blocking defects.

0 open findings

What changed in this PR

Preserves active text edits in the Generate Trace view when pre-validation results refresh.

Changes:

  • Restores focus, draft text, and selection when the field remains unchanged.
  • Adds regression tests for restoration, stale-edit guards, and existing focus and scroll behavior.
File Description
src/​webviews/​trace-configuration/​src/​trace-configuration.ts Preserves active text input across compatible updates.
src/​webviews/​trace-configuration/​src/​trace-configuration.test.ts Adds renderer fixtures and focus-preservation tests.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/webviews/trace-configuration/src/trace-configuration.test.ts

@arneschmid arneschmid left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and can confirm that the focus is now kept. Thanks!

@JonatanAntoni
JonatanAntoni merged commit b854f47 into main Oct 15, 2026
20 checks passed
@JonatanAntoni
JonatanAntoni deleted the keep-focus branch October 15, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants