Skip to content

Enforce package version from release tag - #70

Merged
JonatanAntoni merged 2 commits into
mainfrom
enforce-release-version
Oct 20, 2026
Merged

JonatanAntoni merged 2 commits into
mainfrom
enforce-release-version

Conversation

@JonatanAntoni

Copy link
Copy Markdown
Member

No description provided.

@qltysh

qltysh Bot commented Oct 20, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new tests fail on systems without Bash instead of skipping unavailable shell-dependent checks.

1 open issue
What changed in this PR

Aligns release package versions with release tags and checks archive versions before publication.

Changes:

  • Sets the package version from the release tag during installation.
  • Rejects missing or incorrectly versioned release archives.
  • Adds tests for release version handling and archive validation.

Validation: pytest, pyright, and mypy were not run because project checks are prohibited in this review environment.

File Description
tests/​test_ci_workflow.py Tests workflow version handling and archive validation.
.github/​workflows/​ci.yml Enforces release-tag versions and validates upload assets.

Review effort: Balanced

Comment thread tests/test_ci_workflow.py
Skip CI workflow tests if Bash is not available.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonatanAntoni
JonatanAntoni merged commit 9e51f85 into main Oct 20, 2026
16 checks passed
@JonatanAntoni
JonatanAntoni deleted the enforce-release-version branch October 20, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants