fix: pass instance root to telegram doctor#257
Merged
Conversation
Contributor
|
Thanks for the contribution! This is a clean, targeted fix — the root cause is clear, the change is minimal, and the new tests cover both the initial run and the fix-rerun path. One minor suggestion for future improvements: consider adding Merging this in. Appreciate the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Telegram Doctor command by passing the active OpenACP instance root into
DoctorEngine, matching the CLI doctor path and preventingoptions.dataDirfrom being read fromundefined.Related Issues
None found.
Type of Change
Changes Made
core.instanceContext.roottoDoctorEnginefrom Telegram/doctor, menu callback, and doctor fix callback flows.OpenACPCorethrough Telegram doctor callback registration.Testing
pnpm test— all tests passCommands run:
pnpm vitest run src/plugins/telegram/commands/__tests__/doctor.test.tspnpm vitest run src/plugins/telegram/commands/__tests__/doctor.test.ts src/cli/commands/__tests__/doctor-json.test.ts src/core/doctor/__tests__/telegram-check.test.tspnpm exec tsc --noEmitpnpm buildpnpm testcurrently fails on existing unrelated testsrc/core/agents/__tests__/agent-installer.test.ts > falls back to binary when no npx/uvxon Linux because the fixture only definesdarwin-aarch64binary distribution.Platform Impact
Screenshots / Recordings
Not applicable.
Checklist
.jsextensions)pnpm buildsuccessfullysrc/cli/plugin-template/