fix: format object prompt errors#255
Merged
0xmrpeter merged 1 commit intoMay 18, 2026
Merged
Conversation
Contributor
|
Thank you for the contribution! This is a real and annoying bug — Approved for merge. I'll fix a couple of minor issues in a follow-up commit:
These are non-blocking — merging now and fixing in a follow-up. |
Contributor
Author
|
Thank you! Keep up the good work :)
…On Mon, May 18, 2026, 5:44 AM Mr.Peter ***@***.***> wrote:
Merged #255 <#255> into main.
—
Reply to this email directly, view it on GitHub
<#255 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXEAWYLRH52I6TQDRHKPHQD43KBJPAVCNFSM6AAAAACYXODWRKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRVGYZTSNBYG4YTCNA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prompt failures can be rejected with plain objects instead of
Errorinstances. This PR formats those values into useful messages so users do not seePrompt execution failed: [object Object].Related Issues
None.
Type of Change
Changes Made
Errorinstances, primitive values, nested error objects, and JSON-RPC error data.Testing
pnpm test— all tests passCommands run:
Note:
HOMEwas set to a writable temp directory for the full test run because this local sandbox blocks writes under/Users/m.Platform Impact
Screenshots / Recordings
Not applicable.
Checklist
.jsextensions)pnpm buildsuccessfully