fix: restart when Telegram polling stops#254
Merged
0xmrpeter merged 2 commits intoMay 9, 2026
Merged
Conversation
Contributor
|
Thanks for this fix, @civonafets! This is a real production issue — a silently dead polling loop is exactly the kind of failure that's hard to diagnose, and the supervision approach here is the right call. Merged and then added a few follow-up improvements on top:
Great contribution overall, solid test coverage from the start. 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telegram long polling can stop after the grammY polling promise rejects. The process can stay alive, but no new Telegram messages are consumed.
This change supervises the polling promise. If it rejects during normal runtime, OpenACP requests the normal restart path. During shutdown it does nothing, so stop and restart do not loop. If no restart hook is available, it exits so an external supervisor can start it again.
Also fixes one CLI test mock so the full test suite is isolated from the local daemon state.
Tests: