fix: use a portable file lock for telemetry installation ids - #412
Open
Frankie-Xu wants to merge 1 commit into
Open
fix: use a portable file lock for telemetry installation ids#412Frankie-Xu wants to merge 1 commit into
Frankie-Xu wants to merge 1 commit into
Conversation
Author
|
Please approve Actions workflows for this first-time fork PR so CI can run. |
fcntl.flock is POSIX-only, so importing shared telemetry crashed on Windows before an installation id was even generated. Keep flock on Unix and use msvcrt.locking plus an in-process mutex on Windows.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fcntl.flockis POSIX-only, so importingshared.services.telemetrycrashed on Windows before an installation id was generated (ADR-0004 stable anonymous id).fcntl.flockon Unix. On Windows usemsvcrt.lockingplus an in-process mutex (no new dependency).Test plan
make lintuv run pytest packages/shared-python/shared/tests/test_telemetry_identity.py -q— 7 passed (explicit id, generate UUID, concurrent threads, Windows import without fcntl)uv run pytest apps/api/tests/contract/test_self_hosted_telemetry_contract.py -k installation_id -q— 3 passeduv run pytest apps/api/tests/contract/test_s3_event_contract.py --collect-only -q— 32 tests collected (previously failed onimport fcntl)identity.pyis clean on Windows. Pre-existingPipeConnectionerrors inocr_pages.pyare unchanged and out of scope.Made with Cursor