test: lock connected image inline in assemble_retrieval_results - #409
Open
Frankie-Xu wants to merge 1 commit into
Open
test: lock connected image inline in assemble_retrieval_results#409Frankie-Xu wants to merge 1 commit into
Frankie-Xu wants to merge 1 commit into
Conversation
This was referenced Sep 11, 2026
The Ontos-AI#206 silent drop is already fixed on main. Add assemble-level coverage in test_asset_inline.py instead of a parallel test module.
Frankie-Xu
force-pushed
the
test/Frankie-Xu/assemble-connected-image
branch
from
September 12, 2026 05:38
2762887 to
b7fab9e
Compare
Author
|
Rebased onto current Kept both assemble-level image regressions from this PR:
Resolved the conflict with #410's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #206. Supersedes #331.
Summary
connect_toimage drop inassemble_retrieval_resultsis already fixed onmainby feat: table-embedded images, size filter, and doc_nav top_summary #221 (_connected_display_by_targethandlesimageandtable; missing placeholders are appended).test_asset_inline.py:connect_toand no placeholder in the parent text[images/...]placeholderTest plan
make lintuv run pytest packages/shared-python/shared/tests/test_asset_inline.py -q(7 passed)Made with Cursor