feat(retrieval): add include_document_ids to query - #36
Merged
Conversation
Send the request-level document allowlist on both sync and async retrieval.query. Omitted means unrestricted; empty list is preserved; exclusions still win. Co-authored-by: Cursor <cursoragent@cursor.com>
EricNGOntos
force-pushed
the
feat/wuchengke/retrieval-include-document-ids
branch
from
September 11, 2026 08:26
e6524c2 to
4b567f4
Compare
EricNGOntos
deleted the
feat/wuchengke/retrieval-include-document-ids
branch
September 11, 2026 08:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include_document_idsto sync and asyncretrieval.query.[]is sent as an empty allowlist; exclusions still win.Test plan
uv run ruff check src/ tests/test_retrieval.pyuv run mypy src/knowhereuv run pytest tests/test_retrieval.py(11 passed)Made with Cursor