Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While rapid testing different configurations with some CMake Presets,
I noticed something odd when I was sanity checking the output binaries.
Of note is that the current Wayland build was linking against GLX and X11.
It turns out the culprit was the following line in the cmake build system.
Since Cmake 3.11,
OpenGL_GL_PREFERENCEdefaults toGLVND, whenGLVNDis installed,OpenGL::GLbecomes an umbrella target that linkslibOpenGLandlibGLX. This means usingOpenGL::GLin thewaylandbuild links againstlibGLXdespite not actually using it, ANDlibGLXdepends onlibX11.The fix is simple, changing
OpenGL::GLtoOpenGL::OpenGL. I have attached proofs below.Wayland Before Fix
[jon@Jonny-PC debug-wayland]$ ldd PGEApp linux-vdso.so.1 (0x00007ff84fa08000) libxkbcommon.so.0 => /usr/lib/libxkbcommon.so.0 (0x00007ff84f7ce000) libwayland-client.so.0 => /usr/lib/libwayland-client.so.0 (0x00007ff84f7bd000) libwayland-egl.so.1 => /usr/lib/libwayland-egl.so.1 (0x00007ff84f7b8000) libm.so.6 => /usr/lib/libm.so.6 (0x00007ff84f6b0000) libwayland-cursor.so.0 => /usr/lib/libwayland-cursor.so.0 (0x00007ff84f6a5000) libEGL.so.1 => /usr/lib/libEGL.so.1 (0x00007ff84f693000) libpng16.so.16 => /usr/lib/libpng16.so.16 (0x00007ff84f63e000) >>>>>> libGLX.so.0 => /usr/lib/libGLX.so.0 (0x00007ff84f60c000) libOpenGL.so.0 => /usr/lib/libOpenGL.so.0 (0x00007ff84f5e8000) libz.so.1 => /usr/lib/libz.so.1 (0x00007ff84f5b0000) libdecor-0.so.0 => /usr/lib/libdecor-0.so.0 (0x00007ff84f5a4000) libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x00007ff84f200000) libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x00007ff84f56e000) libc.so.6 => /usr/lib/libc.so.6 (0x00007ff84ee00000) libffi.so.8 => /usr/lib/libffi.so.8 (0x00007ff84f55f000) /lib64/ld-linux-x86-64.so.2 => /usr/lib64/ld-linux-x86-64.so.2 (0x00007ff84fa0a000) libGLdispatch.so.0 => /usr/lib/libGLdispatch.so.0 (0x00007ff84f187000) >>>>>> libX11.so.6 => /usr/lib/libX11.so.6 (0x00007ff84ec9c000) libxcb.so.1 => /usr/lib/libxcb.so.1 (0x00007ff84f530000) libXau.so.6 => /usr/lib/libXau.so.6 (0x00007ff84f182000) libXdmcp.so.6 => /usr/lib/libXdmcp.so.6 (0x00007ff84f17a000)Wayland After Fix
[jon@Jonny-PC debug-wayland]$ ldd PGEApp linux-vdso.so.1 (0x00007f77bbd6e000) libxkbcommon.so.0 => /usr/lib/libxkbcommon.so.0 (0x00007f77bbb34000) libwayland-client.so.0 => /usr/lib/libwayland-client.so.0 (0x00007f77bbb23000) libwayland-egl.so.1 => /usr/lib/libwayland-egl.so.1 (0x00007f77bbb1e000) libm.so.6 => /usr/lib/libm.so.6 (0x00007f77bba16000) libwayland-cursor.so.0 => /usr/lib/libwayland-cursor.so.0 (0x00007f77bba0b000) libEGL.so.1 => /usr/lib/libEGL.so.1 (0x00007f77bb9f9000) libOpenGL.so.0 => /usr/lib/libOpenGL.so.0 (0x00007f77bb9d5000) libpng16.so.16 => /usr/lib/libpng16.so.16 (0x00007f77bb980000) libz.so.1 => /usr/lib/libz.so.1 (0x00007f77bb948000) libdecor-0.so.0 => /usr/lib/libdecor-0.so.0 (0x00007f77bb93e000) libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x00007f77bb600000) libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x00007f77bb5ca000) libc.so.6 => /usr/lib/libc.so.6 (0x00007f77bb200000) libffi.so.8 => /usr/lib/libffi.so.8 (0x00007f77bb92d000) /lib64/ld-linux-x86-64.so.2 => /usr/lib64/ld-linux-x86-64.so.2 (0x00007f77bbd70000) libGLdispatch.so.0 => /usr/lib/libGLdispatch.so.0 (0x00007f77bb551000)