Skip to content

Draw string view #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dandistine wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Draw string view #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
146acd3
Merge pull request #317 from OneLoneCoder/develop
OneLoneCoder Sep 25, 2026
15e5f08
Change draw functions to accept string view.
dandistine Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dev/src/draw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ const GPUTask& olc::Draw::TexturedPolygon(const olc::Structure structure, const
)));
}

const GPUTask& olc::Draw::String(const olc::vf2d& pos, const std::string& text, const olc::Pixel col, const olc::vf2d& scale, olc::Font& font)
const GPUTask& olc::Draw::String(const olc::vf2d& pos, std::string_view text, const olc::Pixel col, const olc::vf2d& scale, olc::Font& font)
{
PrepareTargetForHW();

Expand Down Expand Up @@ -949,7 +949,7 @@ const GPUTask& olc::Draw::String(const olc::vf2d& pos, const std::string& text,
return Batch(task);
}

const GPUTask& olc::Draw::StringProp(const olc::vf2d& pos, const std::string& text, const olc::Pixel col, const olc::vf2d& scale, olc::Font& font)
const GPUTask& olc::Draw::StringProp(const olc::vf2d& pos, std::string_view text, const olc::Pixel col, const olc::vf2d& scale, olc::Font& font)
{
PrepareTargetForHW();

Expand Down Expand Up @@ -979,7 +979,7 @@ const GPUTask& olc::Draw::StringProp(const olc::vf2d& pos, const std::string& te
return Batch(task);
}

olc::vf2d olc::Draw::GetTextSize(const std::string& text, const bool bProportional, const olc::vf2d& scale, olc::Font& font)
olc::vf2d olc::Draw::GetTextSize(std::string_view text, const bool bProportional, const olc::vf2d& scale, olc::Font& font)
{
olc::vf2d size = { 0, font.fLineHeight * scale.y };
olc::vf2d pos = { 0, font.fLineHeight * scale.y };
Expand Down
6 changes: 3 additions & 3 deletions dev/src/draw.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,22 +778,22 @@ namespace olc
// Draws a string at specified location in monospace font
const GPUTask& String(
const olc::vf2d& pos,
const std::string& text,
std::string_view text,
const olc::Pixel col = olc::Colour::WHITE,
const olc::vf2d& scale = { 1.0f, 1.0f },
olc::Font& font = olc::fontClassicPGE);

// Draws a string at specified location in proportional font
const GPUTask& StringProp(
const olc::vf2d& pos,
const std::string& text,
std::string_view text,
const olc::Pixel col = olc::Colour::WHITE,
const olc::vf2d& scale = { 1.0f, 1.0f },
olc::Font& font = olc::fontClassicPGE);

// Returns the bounding box size of a string in pixels
olc::vf2d GetTextSize(
const std::string& text,
std::string_view text,
const bool bProportional = false,
const olc::vf2d& scale = { 1.0f, 1.0f },
olc::Font& font = olc::fontClassicPGE);
Expand Down
12 changes: 6 additions & 6 deletions olcPixelGameEngine3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3454,22 +3454,22 @@ namespace olc
// Draws a string at specified location in monospace font
const GPUTask& String(
const olc::vf2d& pos,
const std::string& text,
std::string_view text,
const olc::Pixel col = olc::Colour::WHITE,
const olc::vf2d& scale = { 1.0f, 1.0f },
olc::Font& font = olc::fontClassicPGE);

// Draws a string at specified location in proportional font
const GPUTask& StringProp(
const olc::vf2d& pos,
const std::string& text,
std::string_view text,
const olc::Pixel col = olc::Colour::WHITE,
const olc::vf2d& scale = { 1.0f, 1.0f },
olc::Font& font = olc::fontClassicPGE);

// Returns the bounding box size of a string in pixels
olc::vf2d GetTextSize(
const std::string& text,
std::string_view text,
const bool bProportional = false,
const olc::vf2d& scale = { 1.0f, 1.0f },
olc::Font& font = olc::fontClassicPGE);
Expand Down Expand Up @@ -18936,7 +18936,7 @@ const GPUTask& olc::Draw::TexturedPolygon(const olc::Structure structure, const
)));
}

const GPUTask& olc::Draw::String(const olc::vf2d& pos, const std::string& text, const olc::Pixel col, const olc::vf2d& scale, olc::Font& font)
const GPUTask& olc::Draw::String(const olc::vf2d& pos, std::string_view text, const olc::Pixel col, const olc::vf2d& scale, olc::Font& font)
{
PrepareTargetForHW();

Expand Down Expand Up @@ -18967,7 +18967,7 @@ const GPUTask& olc::Draw::String(const olc::vf2d& pos, const std::string& text,
return Batch(task);
}

const GPUTask& olc::Draw::StringProp(const olc::vf2d& pos, const std::string& text, const olc::Pixel col, const olc::vf2d& scale, olc::Font& font)
const GPUTask& olc::Draw::StringProp(const olc::vf2d& pos, std::string_view text, const olc::Pixel col, const olc::vf2d& scale, olc::Font& font)
{
PrepareTargetForHW();

Expand Down Expand Up @@ -18997,7 +18997,7 @@ const GPUTask& olc::Draw::StringProp(const olc::vf2d& pos, const std::string& te
return Batch(task);
}

olc::vf2d olc::Draw::GetTextSize(const std::string& text, const bool bProportional, const olc::vf2d& scale, olc::Font& font)
olc::vf2d olc::Draw::GetTextSize(std::string_view text, const bool bProportional, const olc::vf2d& scale, olc::Font& font)
{
olc::vf2d size = { 0, font.fLineHeight * scale.y };
olc::vf2d pos = { 0, font.fLineHeight * scale.y };
Expand Down
Loading