Repository navigation
Org: Guards against invalid data when confirming/finalizing reservations - #2729
Merged
Merged
Conversation
When we detect invalid submission data, we now redirect back to the form view, so those errors can be corrected. Generally it wasn't possible to provoke any errors by using the application normally, but opening the same submission in multiple browser windows/tabs or manually changing the URL can bypass some of the validation, so it's only caught at the very end, when we try to complete the submission. TYPE: Bugfix LINK: ONEGOV-CLOUD-5ZZ
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…on-finalized reservations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message
Org: Guards against invalid data when confirming/finalizing reservations
When we detect invalid submission data, we now redirect back to the form
view, so those errors can be corrected. Generally it wasn't possible to
provoke any errors by using the application normally, but opening the
same submission in multiple browser windows/tabs or manually changing
the URL can bypass some of the validation, so it's only caught at the
very end, when we try to complete the submission.
TYPE: Bugfix
LINK: ONEGOV-CLOUD-5ZZ
Checklist