Conversation
gzeoneth
force-pushed
the
testnode-timeout
branch
from
October 28, 2024 19:52
50be2e6 to
7ac307d
Compare
This reverts commit 355ae13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
--detach --nowaitinstead of manually put the script into background with&so everything is printed to the log, also improved the wait script by greatly shortened timeout and print docker log when timeout for easier debugging.TODO: create
gz-debugPR onnitro-testnodeThis is required for the new
--nowaitflag with some trick to slim down the image so it fit in the github action runnerEDIT: it seems that caching overhead is more than the time it saves (partly due to the image is still larger than what can fit into the cache) so I have caching disabled now