Conversation
spsjvc
marked this pull request as ready for review
August 9, 2024 09:03
spsjvc
changed the title
brtkx
approved these changes
Aug 12, 2024
Member
|
I recommend shipping a version that support both method, migrating all the ci to use the arg method, and then ship another version that disable the input method. Currently before this PR is merged it is hard to pick what to use because the input method would break very soon, while the args method does not work because it wait for token bridge creation. |
spsjvc
marked this pull request as draft
September 30, 2024 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.