Repository navigation
chore(actions): Use org variable for the Octopus space name - #754
Merged
Merged
Conversation
The Octopus space was renamed, so these references need to follow or the release steps will fail against a space that no longer exists. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Reference the org-level Actions variable DEPLOY_K8S_OWNERS_SPACE_NAME instead of hardcoding the space name, so a future space rename is a single change in org settings rather than a PR per repo. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
octonautcal
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Replaces the hardcoded Octopus space name in
.github/workflows/kubernetes-agent-publish-chart.yaml(lines 167 and 174) with the org-level Actions variableDEPLOY_K8S_OWNERS_SPACE_NAME:Applies to both the
push-package-actionandcreate-release-actionsteps.Why
The space is being renamed
Modern Deployments→Swordfish. Hardcoding the name means every rename needs a PR per repo — this round needed 5. Pointing at an org variable makes the next one a single change in org settings.Merge order — this is a no-op on merge
DEPLOY_K8S_OWNERS_SPACE_NAMEcurrently holdsModern Deployments, the space's present name. So merging this changes no behaviour: the workflow resolves to exactly what it resolves to today.The cutover is then a separate, single step, once all of these are merged:
DEPLOY_K8S_OWNERS_SPACE_NAMEtoSwordfishtogether.That keeps the rename decoupled from the code change, instead of needing PR merges and the Octopus rename to land simultaneously.
Prerequisite
DEPLOY_K8S_OWNERS_SPACE_NAMEmust be visible to this repo. This repo is public — worth confirming the org variable's repository access covers it before merging, since an unset variable resolves to an empty string and the action then fails with "The Octopus space name is required".Why not the space id
An id would be truly rename-proof, and
DEPLOY_K8S_OWNERS_SPACE_IDexists. But the actions cannot consume it yet: everything funnels throughresolveSpaceIdin@octopusdeploy/api-client, which filters on?partialName=and demands an exactNamematch, soSpaces-1795throwsNo spaces exist with name 'Spaces-1795'. (push-package-action'saction.ymlclaims "name or ID" — that description is inaccurate.)Upstream fix raised as OctopusDeploy/api-client.ts#293. Once that ships and the actions pick it up, these can move to
DEPLOY_K8S_OWNERS_SPACE_ID.Companions
#754, OctopusDeploy/lobster-watcher#368, OctopusDeploy/octopus-permissions-controller#95, OctopusDeploy/octopus-argocd-gateway#283, and OctopusDeploy/TeamCity-Configuration#130 (TeamCity cannot read GitHub variables, so it is still a direct rename — see note below).
Swordfishinoctopus_space_nameparams, so it breaks the moment it merges and stays broken until the space is actually renamed. It needs to merge with the rename, not before it.🤖 Generated with Claude Code