Skip to content

chore(actions): Use org variable for the Octopus space name - #754

Merged
NickJosevski merged 2 commits into
mainfrom
rename-md-space-to-swordfish
Sep 17, 2026
Merged

NickJosevski merged 2 commits into
mainfrom
rename-md-space-to-swordfish

Conversation

@NickJosevski

@NickJosevski NickJosevski commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

What this does

Replaces the hardcoded Octopus space name in .github/workflows/kubernetes-agent-publish-chart.yaml (lines 167 and 174) with the org-level Actions variable DEPLOY_K8S_OWNERS_SPACE_NAME:

space: "${{ vars.DEPLOY_K8S_OWNERS_SPACE_NAME }}"

Applies to both the push-package-action and create-release-action steps.

Why

The space is being renamed Modern Deployments → Swordfish. Hardcoding the name means every rename needs a PR per repo — this round needed 5. Pointing at an org variable makes the next one a single change in org settings.

Merge order — this is a no-op on merge

DEPLOY_K8S_OWNERS_SPACE_NAME currently holds Modern Deployments, the space's present name. So merging this changes no behaviour: the workflow resolves to exactly what it resolves to today.

The cutover is then a separate, single step, once all of these are merged:

  1. Merge this and its companions (no behavioural change).
  2. Rename the space in Octopus and update DEPLOY_K8S_OWNERS_SPACE_NAME to Swordfish together.

That keeps the rename decoupled from the code change, instead of needing PR merges and the Octopus rename to land simultaneously.

Prerequisite

DEPLOY_K8S_OWNERS_SPACE_NAME must be visible to this repo. This repo is public — worth confirming the org variable's repository access covers it before merging, since an unset variable resolves to an empty string and the action then fails with "The Octopus space name is required".

Why not the space id

An id would be truly rename-proof, and DEPLOY_K8S_OWNERS_SPACE_ID exists. But the actions cannot consume it yet: everything funnels through resolveSpaceId in @octopusdeploy/api-client, which filters on ?partialName= and demands an exact Name match, so Spaces-1795 throws No spaces exist with name 'Spaces-1795'. (push-package-action's action.yml claims "name or ID" — that description is inaccurate.)

Upstream fix raised as OctopusDeploy/api-client.ts#293. Once that ships and the actions pick it up, these can move to DEPLOY_K8S_OWNERS_SPACE_ID.

Companions

#754, OctopusDeploy/lobster-watcher#368, OctopusDeploy/octopus-permissions-controller#95, OctopusDeploy/octopus-argocd-gateway#283, and OctopusDeploy/TeamCity-Configuration#130 (TeamCity cannot read GitHub variables, so it is still a direct rename — see note below).

⚠️ TeamCity #130 does not behave like these four. It hardcodes Swordfish in octopus_space_name params, so it breaks the moment it merges and stays broken until the space is actually renamed. It needs to merge with the rename, not before it.

🤖 Generated with Claude Code

The Octopus space was renamed, so these references need to follow or the
release steps will fail against a space that no longer exists.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 622807e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NickJosevski NickJosevski changed the title Rename Octopus space "Modern Deployments" to "Swordfish" chore(action) Rename space "Modern Deployments" to "Swordfish" Sep 16, 2026
Reference the org-level Actions variable DEPLOY_K8S_OWNERS_SPACE_NAME instead
of hardcoding the space name, so a future space rename is a single change in
org settings rather than a PR per repo.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@NickJosevski NickJosevski changed the title chore(action) Rename space "Modern Deployments" to "Swordfish" Use org variable for the Octopus space name Sep 16, 2026
@NickJosevski NickJosevski changed the title Use org variable for the Octopus space name chore(actions): Use org variable for the Octopus space name Sep 17, 2026
@NickJosevski
NickJosevski merged commit 6f56418 into main Sep 17, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants