Skip to content

refactor: share the "latest" release number rule between server and agent - #300

Merged
matt-richardson merged 19 commits into
mainfrom
mr/go-cli-latest-release-rule
Nov 9, 2026
Merged

matt-richardson merged 19 commits into
mainfrom
mr/go-cli-latest-release-rule

Conversation

@matt-richardson

Copy link
Copy Markdown
Contributor

Merges into #276.

A Deploy release step can't deploy a release number of latest. That rule and its message were written out twice: the step's validation rejects the value on save, and the agent rejects it again at build time for steps saved before the validation existed. The predicate and message now live in octopus-common, and both sides use them, so they can't drift apart. The server check moves into PropertiesValidator with the other shared checks.

Notes:

  • The agent's empty release number check stays where it is. The server already requires the field, and the two messages differ.

🤖 Generated with Claude Code

APErebus and others added 18 commits October 20, 2026 12:21
The Go CLI archives are now downloaded at build time (#282). Drop the
committed cli/ archives and point downloadOctopusCli at resources/cli/.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bring in the per-architecture Go CLI archives (#283). Port the
architecture lookup into cli/OctopusOsUtils and move its test into the
cli package.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…est (#286)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Additional command line arguments reach the Go CLI unchanged. Steps
written for the legacy octo CLI can carry arguments the Go CLI rejects
with only "unknown flag"; the build log now says where the argument
came from.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The Go CLI is bundled for amd64 and arm64 only. Every runner reported
every agent as compatible, so a build could be sent to an agent whose
JVM architecture has no bundled CLI and fail when the step started.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gent

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base automatically changed from ap/default-to-new-cli to main November 5, 2026 04:10
…ase-rule

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@matt-richardson
matt-richardson marked this pull request as ready for review November 5, 2026 04:28
@matt-richardson
matt-richardson merged commit f671473 into main Nov 9, 2026
6 checks passed
@matt-richardson
matt-richardson deleted the mr/go-cli-latest-release-rule branch November 9, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants