Repository navigation
fix: open the build log block each step closes, and keep CLI output lines apart - #298
Merged
Merged
Conversation
The Go CLI archives are now downloaded at build time (#282). Drop the committed cli/ archives and point downloadOctopusCli at resources/cli/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bring in the per-architecture Go CLI archives (#283). Port the architecture lookup into cli/OctopusOsUtils and move its test into the cli package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…est (#286) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Additional command line arguments reach the Go CLI unchanged. Steps written for the legacy octo CLI can carry arguments the Go CLI rejects with only "unknown flag"; the build log now says where the argument came from. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The Go CLI is bundled for amd64 and arm64 only. Every runner reported every agent as compatible, so a build could be sent to an agent whose JVM architecture has no bundled CLI and fail when the step started. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ines apart Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd-output Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
matt-richardson
marked this pull request as ready for review
November 5, 2026 04:27
APErebus
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges into #276.
Two problems in the Go CLI build process. Both were already on
main, but only for steps that opted into the Go CLI. With the legacy CLI removed, every Octopus step hits them.waitFor()closes an "Octopus Deploy" block that nothing opens. TeamCity ignores the unmatched close, so the log isn't broken, but Go CLI steps lose the block that legacy steps grouped their output under. The block now opens before the step's commands run..*patterns, such asspace .* not found, could then match across what were separate lines, and a transient failure could be classified as permanent and not retried. Each line in the copy now ends with a newline, as the legacy capture did.Notes:
runCommandstarts a real process.🤖 Generated with Claude Code