Repository navigation
refactor: resolve a step's space in one place - #258
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
APErebus
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Split out of #239 to make it smaller. The agent read the space name in 13 places across the legacy
*BuildProcessclasses and the Go CLI command builders. #239 changes every one of them to prefer a space id. With the lookup inSpaceSelection, #239 changes one class instead of those eight files.Notes
--space, and the Go CLI sendsDefault.resolveandresolveOrDefaultkeep that difference.--space " "and now omits--space. A name with surrounding spaces is now sent without them on both paths../gradlew build testpasses.🤖 Generated with Claude Code