Skip to content

Fix race in ConnectionsCountForAPollingSubscriptionChangesOneConnectionAtATime #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gb-8 wants to merge 1 commit into from
Closed

Fix race in ConnectionsCountForAPollingSubscriptionChangesOneConnectionAtATime #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions source/Halibut.Tests/Transport/Observability/ConnectionObserverFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,14 @@ public async Task ConnectionsCountForAPollingSubscriptionChangesOneConnectionAtA

await Try.CatchingError(() => echo.SayHelloAsync("hello"));

var closeFirstConnection = connectionsObserver.ConnectionsCountChangedForSubscription.Skip(1).First();
closeFirstConnection.PreviousCount.Should().Be(1);
closeFirstConnection.CurrentCount.Should().Be(0);
closeFirstConnection.SubscriptionId.Should().Be(clientAndService.ServiceUri);
// The failed request is completed before the server releases the connection lease, so the close may not be observed yet.
Wait.UntilActionSucceeds(() =>
{
var closeFirstConnection = connectionsObserver.ConnectionsCountChangedForSubscription.Skip(1).First();
closeFirstConnection.PreviousCount.Should().Be(1);
closeFirstConnection.CurrentCount.Should().Be(0);
closeFirstConnection.SubscriptionId.Should().Be(clientAndService.ServiceUri);
}, TimeSpan.FromSeconds(30), Logger, CancellationToken);

await echo.SayHelloAsync("hello");

Expand Down