Repository navigation
Move to Oceananigans 0.117 - #467
Merged
Merged
Conversation
…igans already provides Oceananigans 0.117 no longer binds either name in Models (default_nan_checker is extended from Diagnostics, iteration from Solvers), so the import failed at precompile. The generic methods, default_nan_checker(model) = nothing and iteration(model::AbstractModel) = model.clock.iteration, already cover a BoxModel on every supported Oceananigans. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ernel expects Oceananigans 0.117 replaced _advect_particles!'s restitution with ParticleBoundaryConditions and added an absorption record. The default reflecting boundary matches the restitution of 1 used before, and nothing records no absorption. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Oceananigans 0.117 gives the particle advection kernel ParticleBoundaryConditions and an absorption record in place of a restitution, and binds default_nan_checker and iteration outside Models. OceanBioME calls the new kernel directly and drops its redundant box-model methods; the compat moves to 0.117 alone, so the version is 0.22.0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dkytezab
changed the title
Oceananigans 0.117 stores a Field's data in a StaticStridesOffsetArray, so the OffsetArray method no longer applied inside kernels. Dispatch on AbstractOffsetArray and index the parent through the array's offsets, which both types provide. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
cc @jagoosw |
tomchor
reviewed
Nov 9, 2026
tomchor
reviewed
Nov 9, 2026
tomchor
approved these changes
Nov 10, 2026
Collaborator
|
@jagoosw I'm going to try and tag a new version. Hope that's okay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves OceanBioME to Oceananigans 0.117. Three of its changes reach OceanBioME:
Oceananigans.Modelsno longer bindsdefault_nan_checkeroriteration(they are extended fromDiagnosticsandSolvers), soBoxModels' import failed at precompile. The box model's own two methods were redundant with the generic ones,default_nan_checker(model) = nothinganditeration(model::AbstractModel) = model.clock.iteration, so both go._advect_particles!takesParticleBoundaryConditionsand an absorption record in place of a restitution.LagrangianAdvectionnow passes the default reflecting boundaries, whose restitution is 1 as before, andnothingfor the record, since OceanBioME removes no particles.Field's data is aStaticStridesOffsetArray(Static dimensions and offsets CliMA/Oceananigans.jl#6270), so the particle tracer uptake's atomic add, which dispatched onOffsetArray, found no method inside kernels. It now dispatches onAbstractOffsetArrayand indexes the parent through the array'soffsets, which both types provide.The compat is 0.117 alone rather than a shim over both kernel signatures, so this is 0.22.0. The docs environment moves with it. No other name OceanBioME imports from Oceananigans changed, and the particle hooks it extends,
step_lagrangian_particles!andupdate_lagrangian_particle_state!, keep their arity and dispatch.Downstream, NumericalEarth pins OceanBioME from
mainin its test environment and cannot move to Oceananigans 0.117 until a release admits it.🤖 Generated with Claude Code