Skip to content

fix: prevent duty loss and fix misleading comment in deadliner #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enlightened88 wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −7
Open

fix: prevent duty loss and fix misleading comment in deadliner #4498

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e32eede
fix: prevent duty loss and fix misleading comment in deadliner
enlightened88 Apr 27, 2026
ac87b6c
Update core/deadline.go
enlightened88 Apr 28, 2026
3fc8728
Update core/deadline.go
enlightened88 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions core/deadline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,16 +176,10 @@ func (d *deadliner) run(ctx context.Context, deadlineFunc DeadlineFunc) {
setCurrState()
}
case <-currTimer.Chan():
// Send deadlined duty to receiver.
select {
case <-ctx.Done():
return
case d.deadlineChan <- currDuty:
default:
log.Warn(ctx, "Deadliner output channel full", nil,
z.Str("label", d.label),
z.Any("duty", currDuty),
)
}

delete(duties, currDuty)
Expand Down Expand Up @@ -217,7 +211,7 @@ func (d *deadliner) C() <-chan Duty {
return d.deadlineChan
}

// getCurrDuty gets the duty to process next along-with the duty deadline. It selects duty with the latest deadline.
// getCurrDuty gets the duty to process next along with the duty deadline. It selects duty with the earliest deadline.
func getCurrDuty(duties map[Duty]bool, deadlineFunc DeadlineFunc) (Duty, time.Time) {
var currDuty Duty

Expand Down