Repository navigation
Conversation
eve/manager.py's read_events used to read events.bin with dtype=oasis_int, which under OASIS_INT=i8 (PiWindDtype's build) read the file at double its real record width, corrupting 1447 real events down to 723 garbage values. That bug is now fixed in OasisLMF (fix/converter-runtime-compat), so this model now correctly processes all 1447 events -- producing a legitimately different (larger, correct) GUL EPT/MELT/PALT output that no longer matches the old, bug-affected expected_results. Regenerated via `pytest tests/test_model_runs.py -k PiWindDtype --update-results` against the fixed oasislmf, and confirmed `--check-results` now passes. gul_S1_summary-info.csv and analysis_settings.json are untouched, as expected (they don't depend on per-event GUL loss computation). Full local suite re-run: 21 passed, 5 skipped, 1 failed (PiWindS3, a pre-existing local environment gap -- missing oasis_data_manager.filestore.backends.aws -- unrelated to this change and not present in CI). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
tests pass with corrected LMF code: OasisLMF/OasisLMF#2193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eve/manager.py's read_events used to read events.bin with dtype=oasis_int, which under OASIS_INT=i8 (PiWindDtype's build) read the file at double its real record width, corrupting 1447 real events down to 723 garbage values. That bug is now fixed in OasisLMF (fix/converter-runtime-compat), so this model now correctly processes all 1447 events -- producing a legitimately different (larger, correct) GUL EPT/MELT/PALT output that no longer matches the old, bug-affected expected_results.
Regenerated via
pytest tests/test_model_runs.py -k PiWindDtype --update-resultsagainst the fixed oasislmf, and confirmed--check-resultsnow passes. gul_S1_summary-info.csv and analysis_settings.json are untouched, as expected (they don't depend on per-event GUL loss computation). Full local suite re-run: 21 passed, 5 skipped, 1 failed (PiWindS3, a pre-existing local environment gap -- missing oasis_data_manager.filestore.backends.aws -- unrelated to this change and not present in CI).for OasisLMF/OasisLMF#2193