Preserve text gates in renamed literal-content elements - #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #482.
When an
ElementPolicyrenamed a container to an element such asstyle, anested allowed element could become the policy's active text container even
though the renderer could not emit its tag inside literal content. That let the
nested text bypass the outer element's text gate.
This change tracks whether a kept literal-content element is open separately
from whether its text is allowed. Nested start tags are treated as dropped
before they can establish another text gate, so their text remains governed by
the outer element. The state is restored when that element closes.
Tests
literal-content element does not allow text.
the nested tag is removed.
closes.
separately reporting its attributes.
./mvnw -ntp -B clean verifypasses on JDK 25: 604 library tests and 7 exampletests.