Close elements emitted at the nesting limit - #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tag balancer emitted an element at the configured nesting limit but used one-level-stricter checks when closing it. Explicit, implicit, ancestor, and document-end closes could therefore leave sanitized HTML unbalanced.
Track whether each logical stack entry was actually sent downstream and use that fact for every close path. This also keeps close decisions correct when
setNestingLimitchanges while a document is open.Regression coverage includes exact serialization, browser-tree equality, sanitizer idempotence, explicit and implicit closes, ancestor closes, document close, pushed-out/resumed table content, and a limit raise after an un-emitted resumed formatting element.
Validation:
./mvnw clean verifywith Homebrew OpenJDK 11, 17, 21, and 25-Djunit.seed=485,342, and20260911Closes #485