Fix review follow-ups for literal text and link balancing - #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #476.
Summary
This fixes the four confirmed follow-ups from review of #463, #465, #466, #467, and #472:
No public API changes are introduced; the library and tests still compile to Java 8 bytecode. Reporting remains batch-first, then one value callback per dropped attribute in input order.
Security and release assessment
The renderer backstop for noscript, noframes, and noembed remains in place. The new hostile tests cover the literal-text splice and CPU cases, all seven formatting markers, policy renaming in both directions, reporter indirection, idempotent sanitization, and validator.nu browser parsing.
The literal-text CPU/splice defects and the policy-layer link round-trip mutation should be fixed before releasing the reviewed literal-text changes. This PR resolves those confirmed blockers. The separately known linear-memory issue #473 remains out of scope and tracked independently.
Verification
All commands passed from the repository root:
Each run includes the normal fuzzers, AntiSamy suite, Java 8 compilation, and JPMS consumer integration check.