test: cover advisories init end to end#852
Open
lntutor wants to merge 1 commit into
Open
Conversation
ELHart05
approved these changes
Jul 19, 2026
ELHart05
left a comment
Contributor
There was a problem hiding this comment.
Thanks for picking this up. Reviewed the change and ran it locally against a synced advisory DB: the new test passes and the full e2e file stays green.
The scope is right. init has no network dependency, so it runs cleanly through the built binary, and you cover both exit-code paths: 0 with the file created on the first run, and 1 with the overwrite error on the second. It reuses the existing harness helpers and sits next to the other command tests. Reads well to me.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end coverage for
cve-lite advisories initthrough the real built CLI.Closes #851
Why this change
The command had unit coverage but no test verifying its process exit codes and filesystem behavior through the distributed binary.
What changed
advisories init --output <temp path>and assert exit code 0.Validation
npm run buildnode dist/index.js advisories syncnpm test -- --runInBand(94 suites, 1,096 tests)User-facing impact
Does this change:
Notes
Test-only change; production behavior is unchanged.