Fix live deploy: retention script on CI runners - #27
Merged
Merged
Conversation
Replace the hardcoded local firebase-tools path with google-auth-library and service account auth, add npm ci to the deploy workflow, and bump checkout to v6. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Visit the preview URL for this PR (updated for commit c7015a1): https://mozaic-56ca8--pr27-fix-live-deploy-rete-lb4wr45i.web.app (expires Thu, 11 Jun 2026 21:06:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ce324a54b3966da2685f33626583cb325e08078c |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The live deploy on
mainfailed after #26 merged — not because of the Node.js 20 deprecation notice.Node.js 20 actions are deprecatedonactions/checkout@v4— GitHub advisory only; preview deploys still succeeded.set-hosting-retention.jsfell back to a hardcoded macOS Homebrew path (/opt/homebrew/Cellar/firebase-cli/...) that does not exist on Linux runners.Fix
google-auth-library+ Firebase Hosting REST API (sameFIREBASE_SERVICE_ACCOUNTcreds)npm cibefore running the script in the live deploy workflowactions/checkout@v4→@v6to clear the Node.js 20 deprecation warningTest plan
mainMade with Cursor