Set /W4 through target_compile_options instead of a bogus define - #147
Merged
rouault merged 1 commit intoAug 11, 2026
Merged
Conversation
Member
yes |
target_compile_definitions() prepends -D, so this passed -D/DW4 and defined a macro named "/DW4" rather than setting the warning level. MSVC tolerates the bogus name; clang-cl rejects it with "error: macro name must be an identifier". Moving it to target_compile_options() applies /W4 as intended.
NathanGray-ChurchillNavigation
force-pushed
the
fix-clang-cl-dw4-define
branch
from
August 10, 2026 21:46
a4079cd to
fbc7a0f
Compare
Contributor
Author
|
Done - switched to |
NathanGray-ChurchillNavigation
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
target_compile_definitions()prepends-D, so this line passed-D/DW4and defined a macro named/DW4. It never set the warning level - the neighbouring calls in the same block use-Dspellings,so
/W4as a compile option looks like what was meant.MSVC tolerates the bogus name. clang-cl rejects it:
Moved to
target_compile_options()so/W4is applied as intended.Verified with clang-cl 22.1.8: libgeotiff 1.7.4 builds clean at
/W4, one warning across the 17translation units (an unused parameter).