v1.8.0 prep#8
Merged
Merged
Conversation
- Updated the package version to 1.8.0. - Introduced new features in FHIR resolution, including `value_as_concept_id` and `value_as_concept_name` columns in the `resolve_batch()` output for composite concepts. - Added `on_unmapped` argument to `resolve()`, `resolve_batch()`, and `resolve_codeable_concept()` methods, allowing users to specify behavior for unmapped concepts. - Updated documentation and examples to reflect these enhancements, ensuring clarity on new functionalities and usage patterns.
…esponding tests - Updated the logic in fhir_batch_to_tibble to correctly identify unmapped concepts, ensuring that only explicit concept_id 0 is labeled as "unmapped" while NA ids are treated as resolved. - Added a new test case to verify that a missing standard id does not mislabel the response as "unmapped", maintaining clarity in the output status. - Enhanced overall test coverage for the resolve_batch function to ensure accurate handling of malformed responses.
Release version 1.8.0 with new FHIR resolution features
- Upgraded actions/checkout from v4 to v6 across all workflows for improved performance and features. - Updated actions/upload-artifact from v4 to v7 in integration and test coverage workflows to leverage new capabilities. - Enhanced deployment action in pkgdown workflow by upgrading from JamesIves/github-pages-deploy-action@v4.5.0 to v4.8.0 for better compatibility and functionality.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Release 1.8.0 adds FHIR Value-as-Concept support and a new
on_unmappedoption, and fixes unmapped labeling in batch results. It also updates GitHub Actions to the latest major versions.New Features
resolve_batch(as_tibble = TRUE)now includesvalue_as_concept_idandvalue_as_concept_namefor composite concepts (FHIR IG “Maps to value”).resolve(),resolve_batch(), andresolve_codeable_concept()accepton_unmapped = "sentinel"to return aconcept_id0 record instead of a 404 (default remains"error").Bug Fixes
standard_concept_id = 0asstatus = "unmapped"with a clear detail, and does not mislabel missing IDs; added tests to cover both cases.Written for commit 1fc5a7e. Summary will update on new commits. Review in cubic