Add active filters to facet count queries - #48
Merged
Merged
Conversation
✅ Deploy Preview for device-database-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PhilipTrauner
approved these changes
Sep 17, 2026
PhilipTrauner
left a comment
PhilipTrauner
left a comment
Collaborator
There was a problem hiding this comment.
thanks, looks good to me 👍
Comment on lines
+50
to
+55
| // with at most one dimension selected both facets share the same query | ||
| const manufacturerDimensionsRequest = | ||
| browseFiltersToHref(categoryFacetFilters) === | ||
| browseFiltersToHref(manufacturerFacetFilters) | ||
| ? categoryDimensionsRequest | ||
| : getDimensions(browseFiltersToQuery(manufacturerFacetFilters)); |
Collaborator
There was a problem hiding this comment.
reducing this to one request when possible is neat 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes OHF-Device-Database/backlog-items#168
The dimensions endpoint was queried once, without filters
Count each facet against every other active filter. The selected facet itself still lists every alternative so several values can be combined, and a selected value that drops to zero stays listed so it can be deselected.