Skip to content

missing rule pattern escape #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilipTrauner merged 1 commit into from
Sep 10, 2026
Merged

missing rule pattern escape #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions project/server/src/service/database/query/derived/device-insert.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ with filtered_deduplicated_attribution_submission as (
snapshot_submission_device ssd1 join (
select value from json_each(@rulePatternManufacturer)
) r on (
ssd1.manufacturer like r.value
ssd1.manufacturer like r.value escape '\\'
)
) and
lower(ssd.manufacturer) not in (select lower(value) from json_each(@ruleLiteralManufacturer)) and
Expand All @@ -46,7 +46,7 @@ with filtered_deduplicated_attribution_submission as (
snapshot_submission_device ssd1 join (
select value from json_each(@rulePatternModel)
) r on (
ssd1.model like r.value
ssd1.model like r.value escape '\\'
)
)
), filtered_counted_device as materialized (
Expand Down
2 changes: 1 addition & 1 deletion project/server/src/service/scheduler/scheduled/derive/device/rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export const pattern = {
"%ONVIF%", // a standard for ip video cameras, not an actual manufacturer
"0x%", // some protocol integrations (mostly fritzbox, but sometimes also matter) provide internal manufacturer code instead of name
"TUYA%", // tuya whitelabel devices (insufficient data quality)
"_T%", // tuya whitelabel devices (insufficient data quality)
"\\_T%", // tuya whitelabel devices (insufficient data quality)
"%???%", // tuya whitelabel devices (insufficient data quality)
],
model: [
Expand Down